-
Notifications
You must be signed in to change notification settings - Fork 15
[DEP-4265] Add depot ci metrics #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cecae5b
feat: add ci metrics command
121watts 6b52dc1
fix: point users to full metrics samples
121watts c76886b
fix: show actionable run metrics limit errors
121watts 47b5472
fix: show job metrics limit errors cleanly
121watts 4f9d544
fix: harden ci metrics unavailable output
121watts d124c87
Merge branch 'main' into watts/dep-4265-ci-metrics-cli
121watts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New "metrics" command missing from registration guard test
Low Severity
The new
metricssubcommand is registered inNewCmdCIbut not added to thewantedslice inTestCICommandRegistrationinci_test.go. That test's comment explicitly says "New verbs should be added to thewantedslice below." Without the entry, a future refactor that accidentally dropscmd.AddCommand(NewCmdMetrics())won't be caught by the guard test.Reviewed by Cursor Bugbot for commit 4f9d544. Configure here.