Skip to content

fix(ci): link status attempts to workflow view #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
121watts merged 1 commit into from
May 7, 2026
Merged

fix(ci): link status attempts to workflow view #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions pkg/cmd/ci/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package ci

import (
"fmt"
"net/url"
"strings"

"github.com/depot/cli/pkg/config"
"github.com/depot/cli/pkg/helpers"
Expand Down Expand Up @@ -81,7 +83,7 @@ func NewCmdStatus() *cobra.Command {
if canDownloadLogExport(attempt.Status) {
fmt.Printf(" Download: depot ci logs %s --output-file %s%s\n", attempt.AttemptId, logDownloadFilename, orgFlag)
}
fmt.Printf(" View: https://depot.dev/orgs/%s/workflows/%s\n", resp.OrgId, attempt.AttemptId)
fmt.Printf(" View: %s\n", statusAttemptViewURL(resp.OrgId, workflow.WorkflowId, job.JobId, attempt.AttemptId))
if attempt.GetSandboxId() != "" && statusIsRunning(attempt.GetStatus()) {
fmt.Printf(" SSH: depot ci ssh %s --job %s%s\n", resp.RunId, job.JobKey, orgFlag)
}
Expand Down Expand Up @@ -172,7 +174,7 @@ func statusToJSON(resp *civ1.GetRunStatusResponse, orgFlag string) statusJSON {
SessionID: attempt.GetSessionId(),
LogsCommand: fmt.Sprintf("depot ci logs %s%s", attempt.GetAttemptId(), orgFlag),
DownloadAvailable: canDownloadLogExport(attempt.GetStatus()),
ViewURL: fmt.Sprintf("https://depot.dev/orgs/%s/workflows/%s", resp.GetOrgId(), attempt.GetAttemptId()),
ViewURL: statusAttemptViewURL(resp.GetOrgId(), workflow.GetWorkflowId(), job.GetJobId(), attempt.GetAttemptId()),
SSHAvailable: attempt.GetSandboxId() != "" && statusIsRunning(attempt.GetStatus()),
}
if a.DownloadAvailable {
Expand All @@ -194,3 +196,19 @@ func statusToJSON(resp *civ1.GetRunStatusResponse, orgFlag string) statusJSON {
func statusIsRunning(status string) bool {
return status != "finished" && status != "failed" && status != "cancelled"
}

func statusAttemptViewURL(orgID, workflowID, jobID, attemptID string) string {
path := fmt.Sprintf("https://depot.dev/orgs/%s/workflows/%s", url.PathEscape(orgID), url.PathEscape(workflowID))

var params []string
if jobID != "" {
params = append(params, "job="+url.QueryEscape(jobID))
}
if attemptID != "" {
params = append(params, "attempt="+url.QueryEscape(attemptID))
}
if len(params) == 0 {
return path
}
return path + "?" + strings.Join(params, "&")
}
3 changes: 2 additions & 1 deletion pkg/cmd/ci/status_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func TestStatusHumanOutputShowsDownloadForFinishedAttemptsOnly(t *testing.T) {
for _, want := range []string{
"Logs: depot ci logs att-finished --org org-123",
"Download: depot ci logs att-finished --output-file logs.txt --org org-123",
"View: https://depot.dev/orgs/org-123/workflows/workflow-1?job=job-1&attempt=att-finished",
"Logs: depot ci logs att-running --org org-123",
"Logs: depot ci logs att-failed --org org-123",
} {
Expand Down Expand Up @@ -159,7 +160,7 @@ func TestStatusJSONOutput(t *testing.T) {
if !attempts[0].DownloadAvailable || attempts[0].DownloadCommand != "depot ci logs att-finished --output-file logs.txt --org org-123" {
t.Fatalf("unexpected finished download affordance: %+v", attempts[0])
}
if attempts[0].ViewURL != "https://depot.dev/orgs/org-123/workflows/att-finished" {
if attempts[0].ViewURL != "https://depot.dev/orgs/org-123/workflows/workflow-1?job=job-1&attempt=att-finished" {
t.Fatalf("finished view url = %q", attempts[0].ViewURL)
}
if !attempts[1].SSHAvailable || attempts[1].SSHCommand != "depot ci ssh run-1 --job ci.yml:build --org org-123" {
Expand Down
Loading