This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Fix axe-cli for release#5
Merged
marcysutton merged 4 commits intomasterfrom Feb 2, 2017
Merged
Conversation
Contributor
Author
|
@WilcoFiers @iandotkelly I ran this on another machine and it only worked with my PR. I think we should merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't run axe-cli at all without these changes–I kept running into Issue #3 and the only way to fix it was to remove the call to
config.driver.quit()in lib/webdriver.js. I couldn't find a way to check for a driver session id before making that call, so the solution was to remove it since it threw an error in.catch(e)in axe-test-urls.js:77, even after results had successfully completed:Removing that call didn't seem to affect the functionality: I could run axe-cli on multiple URLs and it returned results successfully, multiple times in a row. I think when you kill off Phantomjs it takes down the driver anyway, so there is nothing left running on port 4444.
I also added a fix for the Selenium URL since it would return an HTML error page on the Selenium website otherwise.
Closes #3.