docs: minor corrections to rule help/description text #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ma10
commented
Jan 30, 2025
ma10
commented
- fix(hidden-content): Make the description text consistent with others, following the proposal in Make rule descriptions more consistent #4385
- fix(presentation-role-conflict): swap the content of the help and the description
- chore: reflect the changes to the generated files.
WilcoFiers
approved these changes
Feb 12, 2025
Contributor
|
Reviewed for security. |
straker
added a commit
that referenced
this pull request
Mar 31, 2025
…lict (#4738) #4685 made a change that swapped the help and description text of `presentation-role-conflict`, probably in order to put the "Ensure" text as the description (which is what the pr updated). However the description should always been the longer of the text and the help text short. This reverts that change, but updates the description and help text to bring it more in line with the "Ensure" pattern of the description.
ma10
added a commit
to ma10/axe-core
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.