Skip to content

Comments

Filebrowser#3053

Closed
kasbert wants to merge 3 commits intoderailed:masterfrom
kasbert:filebrowser
Closed

Filebrowser#3053
kasbert wants to merge 3 commits intoderailed:masterfrom
kasbert:filebrowser

Conversation

@kasbert
Copy link

@kasbert kasbert commented Jan 8, 2025

Browse container or local files and upload or download selected file or directory.

Pressing 'B' in pod or container view opens a remote file list.
'T' or Space in remote file list downloads the file or directory.
Pressing 'L' in remote file list opens a local file list.
'T' or Space in local file list uploads the file or directory to the previously selected remote directory.

@derailed derailed added the enhancement New feature or request label Jan 19, 2025
derailed
derailed requested changes Jan 20, 2025
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerhard Thank you for this Gerhard!! Very nice feature and useful feature!

internal/dao/dir_remote.go

// It would be better to list files here ?
// No access to view/exec.go, though
txt, ok := ctx.Value(internal.KeyContents).(string)
Copy link
Owner

@derailed derailed Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Not keen on stuffing the dir contents into the context. Best if it worked like local list. I think we should have a util call to list out dir content on a pod. If the container is not specified, we can use the main container.

internal/dao/dir_remote.go
if name == "../" && dir == "/" {
continue
}
//if strings.HasSuffix(name, "/") { // directory
Copy link
Owner

@derailed derailed Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

internal/view/dir_local.go
return d.transferCmd(evt)
}

/*
Copy link
Owner

@derailed derailed Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

internal/view/dir_remote.go
}

/*
v := NewDirRemote(d.fqn, d.co, d.os, dir, str)
Copy link
Owner

@derailed derailed Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

internal/view/dir_remote.go
Retries: defaultTxRetries,
Cancel: func() {},
}
dialog.ShowUploads(d.App().Styles.Dialog(), d.App().Content.Pages, opts)
Copy link
Owner

@derailed derailed Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a base transfer dialog for this. Based on the context aka loca/remote the Download toggle does not mean much anymore and we already know what kind of action should take place ie remote->download local->upload.
Also not keen on the view titles ie Dirlocal or Dirremote perhaps something like Local File System and Remote File System could be more comprehensible??

@derailed derailed added the needs-tlc Pr needs additional updates label Jan 20, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 3, 2025
@github-actions github-actions bot closed this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derailed derailed derailed requested changes

Assignees

No one assigned

Labels

enhancement New feature or request needs-tlc Pr needs additional updates stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kasbert @derailed @jarkkosonninen