Center log indicator#696
Merged
derailed merged 1 commit intoderailed:masterfrom May 7, 2020
ckoehn:fix/center-log-indicator
Merged
Center log indicator#696derailed merged 1 commit intoderailed:masterfrom ckoehn:fix/center-log-indicator
derailed merged 1 commit intoderailed:masterfrom
ckoehn:fix/center-log-indicator
Conversation
derailed
reviewed
May 6, 2020
| @@ -107,5 +108,5 @@ func (l *LogIndicator) onOff(b bool) string { | |||
| } | |||
|
|
|||
| func (l *LogIndicator) update(status string) { | |||
Owner
There was a problem hiding this comment.
@ckoehn Thank you for this PR! Good eye!! I think we could refactor the update method as follows:
Does this make sense?
func (l *LogIndicator) update(title string, state bool, pad ...bool) {
var padding string
if len(pad) == 0 {
padding = spacer
}
fmt.Fprintf(l, "[::b]%s:%s%s", title, l.onOff(state), padding)
}
Contributor
Author
There was a problem hiding this comment.
I didn't understand why pad is a variadic argument and changed it to a non-variadic one.
Owner
There was a problem hiding this comment.
Yes that's fine. Thank you Christian!
Previously all options were padded with spaces which caused the indicator to be visually uncentered.
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Center log indicator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all options were padded with spaces which caused the indicator to be visually uncentered.