Skip to content

Fixed test-containers#30

Merged
deruzh merged 2 commits intomainfrom
testing/test-containers
May 10, 2025
Merged

Fixed test-containers#30
deruzh merged 2 commits intomainfrom
testing/test-containers

Conversation

@deruzh
Copy link
Copy Markdown
Contributor

@deruzh deruzh commented May 8, 2025

  1. Added logger implementation that adds config to testing
  2. Now tests skip when docker is disabled

Closes #29

@deruzh deruzh requested review from animeemorave and nznyx May 8, 2025 13:08
nznyx
nznyx approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@nznyx nznyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a smol silly kitten

@deruzh deruzh linked an issue May 10, 2025 that may be closed by this pull request
[SDK:TestClasses] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". #28
Closed
@deruzh deruzh merged commit f754ba1 into main May 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nznyx nznyx nznyx approved these changes

@animeemorave animeemorave Awaiting requested review from animeemorave

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make TestContainers more usable [SDK:TestClasses] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".

2 participants

@deruzh @nznyx