Feat/claude skill package#13
Merged
Merged
Conversation
Implements SPEC §T13. Plugin metadata at
plugins/codeforerunner/.codex-plugin/plugin.json mirrors upstream
caveman shape (skills glob + interface block). Skill body at
plugins/codeforerunner/skills/codeforerunner/SKILL.md is byte-equal
to agent/codeforerunner.skill.md post-frontmatter content per §V10.
- Rename design doc §"Proposed Layout" → §"Package Layout"; annotate
layout block with per-task impl status (T13 done, T14/T15 planned).
- Drop resolved Open Decision bullet on build-time vs checked-in
skill files; T13 picked checked-in.
- Add LICENSES/LicenseRef-Codeforerunner-SAL-0.1.txt mirroring root
LICENSE.md so REUSE-spec scanners resolve the custom license ref
used in plugin.json.
- Mark T13 done in SPEC and roadmap.
Closes T13.
Contributor
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR establishes the foundational distribution infrastructure for Codeforerunner by introducing a canonical skill instruction, Claude and Codex plugin manifests, a source-available license, and formal specification of the skill contract alongside concrete distribution design documentation. ChangesSkill Distribution and Plugin Manifests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
plugins/codeforerunner/skills/codeforerunner/SKILL.md (2)
76-76:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winClarify Claude vs. generic distribution paths.
Line 76 lists both "Claude" and "generic" as using
skills/codeforerunner/SKILL.md, which is confusing. Perdocs/agent-distribution-design.md, Claude distribution is implemented at that path while generic distribution is proposed. The text should clarify whether they share the same file or use distinct paths.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/codeforerunner/skills/codeforerunner/SKILL.md` at line 76, The sentence conflates "Claude" and "generic" distributions by implying they both use the same SKILL.md; update the wording so it explicitly states that the Claude distribution uses the implemented SKILL.md for Claude and that the generic distribution is a proposed/alternative SKILL.md (i.e., clarify whether they share a single SKILL.md or require distinct SKILL.md files), and adjust the text to name the two distribution types ("Claude distribution" and "generic distribution") so readers know which path is implemented vs. proposed.
6-8:⚠️ Potential issue | 🟠 Major | ⚡ Quick winClarify canonical source designation.
This file claims to be "the canonical instruction source" but
SPEC.md(line 25, I.agent-skill) designatesagent/codeforerunner.skill.mdas the canonical source. According to the review context, this file is the Codex distribution copy.Distribution copies should clarify their relationship to the canonical source to prevent maintainers from editing distribution files instead of the source.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/codeforerunner/skills/codeforerunner/SKILL.md` around lines 6 - 8, Update the top matter and first paragraph in the document titled "# codeforerunner Skill — Canonical Source" to clearly mark this file as a distribution/codex copy and not the authoritative source: mention that the true canonical instruction source is the agent skill referenced by SPEC.md's I.agent-skill entry and instruct maintainers to edit the canonical agent skill document instead of this distribution copy; ensure the wording replaces or augments "the **canonical instruction source**" so readers aren’t misled and include a short note pointing to SPEC.md I.agent-skill for the authoritative location.
🧹 Nitpick comments (1)
agent/codeforerunner.skill.md (1)
1-83: 🏗️ Heavy liftVerify downstream file synchronization mechanism.
This file is designated as the canonical skill source per
SPEC.mdI.agent-skill and V10. The distributed variants (skills/codeforerunner/SKILL.mdandplugins/codeforerunner/skills/codeforerunner/SKILL.md) must preserve this file's post-frontmatter content verbatim.All three files currently have identical content, but there's no visible mechanism (script, CI check, or installer) ensuring the distribution files stay synchronized with changes to this canonical source. Manual synchronization is error-prone.
Consider adding validation (e.g., in CI or via a
doctorcommand) to detect drift between the canonical source and distribution copies.Would you like me to generate a validation script that can detect content drift between the canonical source and distribution files?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agent/codeforerunner.skill.md` around lines 1 - 83, The canonical skill file codeforerunner.skill.md is required to be verbatim across distributed copies (skills/codeforerunner/SKILL.md and plugins/codeforerunner/skills/codeforerunner/SKILL.md) but there is no automation detecting drift; add a validation that compares the post-frontmatter body of codeforerunner.skill.md against the two distributed SKILL.md files and fails CI on mismatch (or expose as a doctor command). Implement the check as a script/CI job that: reads and strips frontmatter from the canonical file and the two target files, performs a normalized comparison (trim, unify line endings), and returns a non-zero exit code with a clear message if any differences exist; reference SPEC.md V10 in the job description and include the three filenames in the check so maintainers can locate the affected files.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/codeforerunner/SKILL.md`:
- Line 76: The sentence listing downstream files is ambiguous about whether
Claude's distribution and the proposed generic distribution share the same
skills/codeforerunner/SKILL.md path; update the text in SKILL.md to explicitly
state whether the Claude distribution (referenced by .claude-plugin/plugin.json
+ skills/codeforerunner/SKILL.md) is the canonical implemented file and the
generic distribution will reuse that same path in T15, or if the generic
distribution will have a separate path (specify the distinct path) — edit the
clause that mentions "Claude `.claude-plugin/plugin.json` +
`skills/codeforerunner/SKILL.md` and generic `skills/codeforerunner/SKILL.md`"
to clearly indicate one of the two options and, if separate, name the
alternative path and update docs/agent-distribution-design.md references
accordingly.
- Around line 6-8: Change the misleading header and description in the SKILL.md
distribution copy: replace the heading "# codeforerunner Skill — Canonical
Source" with something like "# codeforerunner Skill — Distributed Copy" and
update the description paragraph that currently calls this file "the canonical
instruction source" to clearly state that this is a distribution copy and that
the authoritative canonical source is "agent/codeforerunner.skill.md" (as
referenced in SPEC.md I.agent-skill); keep the rest of the content verbatim per
spec.
---
Duplicate comments:
In `@plugins/codeforerunner/skills/codeforerunner/SKILL.md`:
- Line 76: The sentence conflates "Claude" and "generic" distributions by
implying they both use the same SKILL.md; update the wording so it explicitly
states that the Claude distribution uses the implemented SKILL.md for Claude and
that the generic distribution is a proposed/alternative SKILL.md (i.e., clarify
whether they share a single SKILL.md or require distinct SKILL.md files), and
adjust the text to name the two distribution types ("Claude distribution" and
"generic distribution") so readers know which path is implemented vs. proposed.
- Around line 6-8: Update the top matter and first paragraph in the document
titled "# codeforerunner Skill — Canonical Source" to clearly mark this file as
a distribution/codex copy and not the authoritative source: mention that the
true canonical instruction source is the agent skill referenced by SPEC.md's
I.agent-skill entry and instruct maintainers to edit the canonical agent skill
document instead of this distribution copy; ensure the wording replaces or
augments "the **canonical instruction source**" so readers aren’t misled and
include a short note pointing to SPEC.md I.agent-skill for the authoritative
location.
---
Nitpick comments:
In `@agent/codeforerunner.skill.md`:
- Around line 1-83: The canonical skill file codeforerunner.skill.md is required
to be verbatim across distributed copies (skills/codeforerunner/SKILL.md and
plugins/codeforerunner/skills/codeforerunner/SKILL.md) but there is no
automation detecting drift; add a validation that compares the post-frontmatter
body of codeforerunner.skill.md against the two distributed SKILL.md files and
fails CI on mismatch (or expose as a doctor command). Implement the check as a
script/CI job that: reads and strips frontmatter from the canonical file and the
two target files, performs a normalized comparison (trim, unify line endings),
and returns a non-zero exit code with a clear message if any differences exist;
reference SPEC.md V10 in the job description and include the three filenames in
the check so maintainers can locate the affected files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 78ccc7ca-71fc-4969-aab9-9399f4219b09
📒 Files selected for processing (10)
.claude-plugin/plugin.jsonLICENSES/LicenseRef-Codeforerunner-SAL-0.1.txtREADME.mdSPEC.mdagent/codeforerunner.skill.mddocs/agent-distribution-design.mddocs/roadmap.mdplugins/codeforerunner/.codex-plugin/plugin.jsonplugins/codeforerunner/skills/codeforerunner/SKILL.mdskills/codeforerunner/SKILL.md
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Chores