Modernize string formatting to f-strings#201
Merged
Merged
Conversation
- Convert all .format() and % formatting to f-strings across codebase - Update ruff config to remove UP031/UP032 ignores (Python 2 legacy) - Add noqa comments to dynamic template .format() calls (can't convert to f-strings) - Use SimpleNamespace for dot notation access in test_variations.py - Refactor __repr__ method for improved readability - All 1182 tests pass, ruff checks pass Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernized all string formatting across the codebase from Python 2-era styles (% formatting,
.format()) to Python 3.10+ f-strings.Changes
.format()and%formatting to f-strings across main code, tests, and docs.format()calls that can't be converted (e.g.,string_format.format(**dict))SimpleNamespacefor dot notation access intest_variations.py__repr__method in parser.py for better readability—broke long f-string into multi-lineattrsconstructionFiles Changed
nameparser/parser.py: Converted .format() and % formatting to f-strings, refactored reprnameparser/config/__init__.py: Converted .format() to f-string in SetManager.reprtests/test_variations.py: Converted to f-strings with SimpleNamespace for dot notationtests/base.py: Converted % formatting to f-strings in assertion messagesdocs/conf.py: Converted .format() with format spec to f-stringpyproject.toml: Removed UP031 and UP032 from ruff ignore listTesting
✅ All 1182 tests pass
✅ All ruff checks pass (including the now-enabled UP031/UP032 rules)