patch sql encoding bug in Queue Plugin #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There was a problem hiding this comment.
Please use (int)$id as per CS
Contributor
Author
There was a problem hiding this comment.
Is this a good idea? Probably not when using uuids for id's
Owner
There was a problem hiding this comment.
You maybe also use value() there then. But I don't think anyone would ever use UUIDs for the QueuedTask table.
Owner
|
Do you happen to have a test case along with this maybe? |
Owner
|
Any update on how to reproduce (what query etc) and a test case maybe? |
Contributor
Author
|
Sorry, I didn't have time yet. I'll try to get to it this week. Thanks for the reminder. |
Owner
|
Well... :) |
dereuromark
pushed a commit
that referenced
this pull request
Dec 12, 2014
…sage patch sql encoding bug in Queue Plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failureMessage is not escaped for the DB when trying to write the failure message in markJobFailed.