Skip to content

Use escapeTitle in pagination element#483

Merged
dereuromark merged 1 commit intomasterfrom
fix/escape-title-pagination
Apr 30, 2026
Merged

Use escapeTitle in pagination element#483
dereuromark merged 1 commit intomasterfrom
fix/escape-title-pagination

Conversation

@dereuromark
Copy link
Copy Markdown
Owner

Using 'escape' => false on Paginator helpers also disables HTML escaping of attributes (URL, class, title attr), not just the title text. The narrower 'escapeTitle' => false keeps attribute escaping on while still allowing the icon markup in the title.

Affects templates/element/pagination.php only.

Before After
['escape' => false] ['escapeTitle' => false]

Defense-in-depth — no known exploit path because the call sites pass static strings, but keeping the strict default protects against future edits that wire dynamic values into pagination options.

Using 'escape' => false also disables HTML escaping of attributes (URL, classes, title), not just the title text. The narrower 'escapeTitle' => false keeps attribute escaping on while still allowing the icon HTML in the title.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 30, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.37%. Comparing base (53865a7) to head (6628a42).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #483   +/-   ##
=========================================
  Coverage     77.37%   77.37%           
  Complexity      962      962           
=========================================
  Files            45       45           
  Lines          3231     3231           
=========================================
  Hits           2500     2500           
  Misses          731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereuromark dereuromark merged commit 34e8050 into master Apr 30, 2026
16 checks passed
@dereuromark dereuromark deleted the fix/escape-title-pagination branch April 30, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants