Document executeAllowedCommands in app.example and upgrading guide#486
Merged
dereuromark merged 1 commit intomasterfrom May 2, 2026
Merged
Document executeAllowedCommands in app.example and upgrading guide#486dereuromark merged 1 commit intomasterfrom
dereuromark merged 1 commit intomasterfrom
Conversation
Add the new allow-list config option to config/app.example.php (the canonical inventory of Queue.* knobs) so users wiring up the plugin discover that production needs it. Add an upgrading-doc subsection covering both the per-token escapeshellarg switch (callers with multi-token single-param entries must split them) and the production allow-list requirement.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
=========================================
Coverage 77.54% 77.54%
Complexity 966 966
=========================================
Files 45 45
Lines 3238 3238
=========================================
Hits 2511 2511
Misses 727 727 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #485. The merged change introduced
Queue.executeAllowedCommandsand a behavior change for callers that previously embedded multiple tokens in a singleparamsentry, but neither showed up in the two places users look first.config/app.example.phpis the canonical inventory of everyQueue.*knob (every other option is listed there with a one-line comment). The new allow-list key is now there too, with a short note that production rejects every Execute job when the list is empty/unset.docs/sections/upgrading.mdnow has anExecuteTask security hardeningsubsection that flags both the param-splitting BC break and the production allow-list requirement, so anyone upgrading from a release prior to Harden ExecuteTask with per-arg escapeshellarg and allow-list #485 sees it before things mysteriously start failing.No code or logic changes; PHP lint clean on
app.example.php.