Removed config keys for <table>Plugin Now use the standard dot notation.

[mtancoigne]

As I can't make the tests yet, let's Travis do this...

[mtancoigne]

Great... I'll look at this tomorrow...

It seems legit, I did not create a pivotTable value for tests :) @bravo-kernel Happy exceptions :)

[dereuromark]

Wow, doesn't that look way cleaner and easier?

[dereuromark]

Did you remove the autodetect here? In case no config is provided? Should we?

[bravo-kernel]

I personally prefer the exception and less magic,

[mtancoigne]

I'copy/paste the discussion with @bravo-kernel wich bring me here:

[22:23:12 CET] <elcms> ok, let sum this up
[22:23:40 CET] <elcms> we keep usersTable, rolesTable, pivotTable
[22:23:51 CET] <bravo_kernel> check
[22:24:17 CET] <elcms> if pivotTable is empty and we are in multi-group, throw an error for misconfiguration
[22:24:55 CET] <elcms> else, do as natural with the given config : test the strings and load the models
[22:25:18 CET] <bravo_kernel> sounds good to me
[22:25:24 CET] <bravo_kernel> i like exceptions for misconfigurations
[22:25:40 CET] <elcms> me too
[22:25:44 CET] <bravo_kernel> cool :)

TL;DR; we get rid of autoconfig and throw an exception if the pivot table is missing, so we don't even need to parse the table name for a plugin in it.

[bravo-kernel]

@mtancoigne could you please try to prevent pasting personal info into public resource?

Final question about this PR; does this work for namespaced plugins as well? E.g. MyCorp\Plugin.TableClass?

[bravo-kernel]

This message make me think the table does not exist (in the database). Maybe change it to something like below, would make it consistent with the other feedback as well.

Invalid TinyAuthorize MultiRole Setup (no pivot table found in Configure)

[mtancoigne]

Sorry for the paste...

[dereuromark]

I agree. But since we have that logic here why do we not use conventions to find it? The error will then come from the orm and will say exaxtly what it said so far.

[bravo-kernel]

@dereuromark I guess it's a preference thing. I always appreciate being informed about the root cause as concrete as possible and this would point me straight to Tiny's config but I can live with the ORM exception as well. Your plugin... your call ☺️

[dereuromark]

Since its cached performance is not an issue :)
I like convention driven. But maybe later