Fix mobile text selection detection for highlighting #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etection Replace mouseup/touchend handlers with selectionchange event listener for more reliable mobile text selection detection. This fixes the issue where the highlight button required an extra tap to become active on mobile devices. - Extract selection checking logic into shared checkSelection function - Use selectionchange event with requestAnimationFrame for immediate detection - Remove onMouseUp and onTouchEnd props from VideoEmbedProcessor - Simplify code by eliminating separate mouse/touch event handlers
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace mouseup/touchend event handlers with
selectionchangeevent listener for more reliable mobile text selection detection. This fixes the issue where the highlight button required an extra tap to become active on mobile devices by providing immediate feedback when text is selected.checkSelectionfunctionselectionchangeevent withrequestAnimationFramefor immediate detectionVideoEmbedProcessor