Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Nov 23, 2023

Changes:

  • Manual flow validation

Screenshots:

image

@vercel
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 24, 2023 3:38am

@coveralls
Copy link

coveralls commented Nov 23, 2023

Coverage Status

coverage: 28.181% (+0.001%) from 28.18%
when pulling f70733e on farhan-nurzi-deriv:farhan/manual-upload-validation
into 7461f99 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11704](https://github.com/binary-com/deriv-app/pull/11704)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-manual-uplo-368de8.binary.sx?qa_server=red.derivws.com&app_id=24099
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-manual-uplo-368de8.binary.sx
- **App ID**: `24099`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-manual-uplo-368de8.binary.sx/

adrienne-deriv
adrienne-deriv previously approved these changes Nov 23, 2023
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adrienne-deriv
adrienne-deriv previously approved these changes Nov 23, 2023
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost previously approved these changes Nov 23, 2023
@farhan-nurzi-deriv farhan-nurzi-deriv dismissed stale reviews from ghost and adrienne-deriv via f70733e November 24, 2023 03:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@yashim-deriv yashim-deriv merged commit b26e461 into deriv-com:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants