Skip to content

Multiple sequences, first draft with simple test#19

Merged
derrickreimer merged 7 commits intoderrickreimer:masterfrom
samsondav:sam/multiple_sequences
Jan 23, 2016
Merged

Multiple sequences, first draft with simple test#19
derrickreimer merged 7 commits intoderrickreimer:masterfrom
samsondav:sam/multiple_sequences

Conversation

@samsondav
Copy link
Copy Markdown

EDIT: OK, I'm reasonably satisfied with this now.

@djreimer thoughts?

@samsondav samsondav force-pushed the sam/multiple_sequences branch from 6664e5f to 2a75245 Compare January 18, 2016 18:32
Comment thread test/dummy/db/schema.rb
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happened because I actually ran the migrations in the dummy app... which probably wasn't necessary.

@derrickreimer
Copy link
Copy Markdown
Owner

This is looking pretty good @samphilipd! I'll take a closer look shortly, but at first glance it looks to be about ready to ship.

@derrickreimer
Copy link
Copy Markdown
Owner

For bookkeeping - addresses #18

derrickreimer added a commit that referenced this pull request Jan 23, 2016
Multiple sequences, first draft with simple test
@derrickreimer derrickreimer merged commit b5d5f53 into derrickreimer:master Jan 23, 2016
@samsondav samsondav deleted the sam/multiple_sequences branch January 24, 2016 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants