feat(sdk): implement management sdk parity between node-sdk and go-sdk#760
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe assignment strategy prioritizes recent contributors who have worked on the specific modules impacted by this PR, ensuring reviewers have relevant and up-to-date knowledge across different areas of the SDK.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
This PR adds ~40 management SDK methods for node/go parity across access keys, audit, authz, FGA, JWT templates, lists, scope-claim mappings, users, and more.
Sniffed out 1 issue:
- 1 🔴 CRITICAL:
paths.tswas never updated — ~61 referenced endpoint keys don't exist, breaking compilation and every new method.
See the inline comment. This one won't hunt until it's fed — needs a bath! 🛁
|
@shuni see review comments and fix if needed, and check ci failures |
|
🐕 Done! Updated PR: #760 📋 Actions TakenView AI responseI've fixed the PR. Here's what was wrong and what I did. Root causeThe parity PR added ~40 new management methods but never updated the supporting layers, so the package didn't compile:
Changes (5 files, 1 commit on
|
The parity methods referenced ~60 apiPaths keys and several types that were never added, so the package failed to compile. - paths.ts: add endpoints for the new access key/permission/role batch ops, audit webhook, FGA dry-run & mappable resources, JWT templates, lists, scope-claim mappings, analytics, project delete, SSO app secret/rotate, SSO redirect/recalculate, tenant SSO link revoke, impersonate step-up, and the new user recovery/custom-attribute/passkey/trusted-device ops. - types.ts: add FGASchemaDryRunResponse, FGAMappable* types, InboundApplicationTenantConsentDeleteOptions, SSOApplicationSecretResponse. - list.ts: drop the invalid SdkResponse<boolean> annotation on checkIP/checkText (core-js SdkResponse requires an object type). - add tests covering the previously untested list and jwtTemplate methods to restore coverage thresholds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
asafshen
left a comment
There was a problem hiding this comment.
one comment about the changed code
descope/etc#16608
View workflow run
API Error: The operation timed out.
Created by Shuni 🐕