Skip to content

feat(sso-app): add default signature method#787

Merged
dorsha merged 2 commits intomainfrom
sso-app-default-signature-method
Mar 16, 2026
Merged

feat(sso-app): add default signature method#787
dorsha merged 2 commits intomainfrom
sso-app-default-signature-method

Conversation

@dorsha
Copy link
Member

@dorsha dorsha commented Mar 16, 2026

Related Issues

https://github.com/descope/etc/issues/14607

Description

feat(sso-app): add default signature method

Must

  • Tests
  • Documentation (if applicable)

@dorsha dorsha requested review from aviadl and Copilot March 16, 2026 16:24
@shuni-bot-dev
Copy link

shuni-bot-dev bot commented Mar 16, 2026

🐕 Review complete — View session on Shuni Portal 🐾

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for specifying a default SAML response signature algorithm when creating/updating SSO applications, with corresponding test updates.

Changes:

  • Add default_signature_algorithm to SAML SSO application create/update APIs and include it in the request body as defaultSignatureAlgorithm.
  • Extend SSO application tests to assert the new request payload field for create (and None for update).
  • Reformat exchange_access_key request body construction; update VS Code settings and gitignore entries.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
descope/management/sso_application.py Adds default_signature_algorithm parameter and maps it into the SAML create/update request body.
tests/management/test_sso_application.py Updates SAML app tests to include/expect defaultSignatureAlgorithm.
descope/auth.py Minor refactor/formatting of loginOptions construction.
.vscode/settings.json Replaces placeholder with explicit UI color customizations.
.gitignore Adds .vscode/ to ignored paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

@shuni-bot-dev shuni-bot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds default_signature_algorithm parameter to SAML SSO application create/update methods and wires it through to the request body.

No issues found — good bones! The new field is consistently added to all three relevant methods (create_saml_application, update_saml_application, _compose_create_update_saml_body), docstrings are updated, and tests cover both create and update flows.

Two minor notes (not blocking):

  • .vscode/settings.json changes are unrelated IDE customizations — consider splitting them out. Adding .vscode/ to .gitignore won't untrack the already-tracked file.
  • The load() docstring (line 326) has a sample JSON for samlSettings that doesn't include defaultSignatureAlgorithm — could be updated for completeness.

Woof!

@github-actions
Copy link

Coverage report

The coverage rate went from 98.34% to 98.34% ➡️

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@dorsha dorsha enabled auto-merge (squash) March 16, 2026 19:37
@dorsha dorsha merged commit e79b0b8 into main Mar 16, 2026
30 checks passed
@dorsha dorsha deleted the sso-app-default-signature-method branch March 16, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants