feat(sso-app): add default signature method#787
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
There was a problem hiding this comment.
Pull request overview
Adds support for specifying a default SAML response signature algorithm when creating/updating SSO applications, with corresponding test updates.
Changes:
- Add
default_signature_algorithmto SAML SSO application create/update APIs and include it in the request body asdefaultSignatureAlgorithm. - Extend SSO application tests to assert the new request payload field for create (and
Nonefor update). - Reformat
exchange_access_keyrequest body construction; update VS Code settings and gitignore entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
descope/management/sso_application.py |
Adds default_signature_algorithm parameter and maps it into the SAML create/update request body. |
tests/management/test_sso_application.py |
Updates SAML app tests to include/expect defaultSignatureAlgorithm. |
descope/auth.py |
Minor refactor/formatting of loginOptions construction. |
.vscode/settings.json |
Replaces placeholder with explicit UI color customizations. |
.gitignore |
Adds .vscode/ to ignored paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
🐕 Shuni's Review
Adds default_signature_algorithm parameter to SAML SSO application create/update methods and wires it through to the request body.
No issues found — good bones! The new field is consistently added to all three relevant methods (create_saml_application, update_saml_application, _compose_create_update_saml_body), docstrings are updated, and tests cover both create and update flows.
Two minor notes (not blocking):
.vscode/settings.jsonchanges are unrelated IDE customizations — consider splitting them out. Adding.vscode/to.gitignorewon't untrack the already-tracked file.- The
load()docstring (line 326) has a sample JSON forsamlSettingsthat doesn't includedefaultSignatureAlgorithm— could be updated for completeness.
Woof!
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
Related Issues
https://github.com/descope/etc/issues/14607
Description
feat(sso-app): add default signature method
Must