Skip to content

Bgs main update#581

Merged
geordie666 merged 8 commits into
desihub:masterfrom
qmxp55:bgsMain_update
Feb 7, 2020
Merged

Bgs main update#581
geordie666 merged 8 commits into
desihub:masterfrom
qmxp55:bgsMain_update

Conversation

@qmxp55
Copy link
Copy Markdown
Contributor

@qmxp55 qmxp55 commented Feb 4, 2020

I've updated the BGS MAIN target selection with two main changes.

  1. We have relaxed our Fibre Magnitude Cut
  2. We manually include the LSLGA galaxies as this are being rejected in DR8. I did not find the 'REF_CAT' parameter so I add it in '_prepare_optical_wise'.

I'll update the wiki in a bit.

Comment thread py/desitarget/cuts.py Outdated
@qmxp55
Copy link
Copy Markdown
Contributor Author

qmxp55 commented Feb 4, 2020

@moustakas: I've made a few changes and now it passes Travis tests.

Copy link
Copy Markdown
Contributor

@geordie666 geordie666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the specific point I've commented on, please also update the:

doc/changes.rst

file to document PR #581.

Comment thread py/desitarget/cuts.py Outdated
@geordie666
Copy link
Copy Markdown
Contributor

@qmxp55: Thanks for the updates. Unless @moustakas has additional requests, I'll merge this later today.

@geordie666 geordie666 merged commit 9046703 into desihub:master Feb 7, 2020
qmxp55 pushed a commit to qmxp55/desitarget that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants