Preserve output table units with new version of astropy #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think I have the fix ready but I want to check that the new unit test fails before deploying it, and travis isn't going anywhere fast... |
Member
Author
|
The travis tests failed on cue with astropy 1.3.2. Now testing the fix... |
Member
Author
|
Tests are passing now, so this is ready to review. |
sbailey
approved these changes
Apr 18, 2017
Contributor
sbailey
left a comment
sbailey
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the quick fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to fix #62