add ISC License template to license picker

[saschanaz]

ISC is the default license for npm packages (in other words, npm init sets ISC by default), but currently GitHub Desktop does not include it by default so I have to manually copy-paste from https://choosealicense.com/licenses/isc/.

Can we include ISC so that users can select it from "Create a new repository" window?

[shiftkey]

@saschanaz thanks for the report. We consume the list of licenses from choosealicense but we only embed the ones that are marked as hidden: false to avoid showing the full list of overwhelming options.

The code that's responsible for this is found here:

desktop/script/build.ts

Line 406 in 568711c

function generateLicenseMetadata(outRoot: string) {

And in particular this bit:

desktop/script/build.ts

Lines 425 to 427 in 568711c

	if (!license.hidden) {
	licenses.push(license)
	}

You'll see that the MIT License from that repository has hidden: false at the start of the file:

---
title: MIT License
spdx-id: MIT
featured: true
hidden: false

...

But the ISC license does not. I believe this has been due to it being very similar to MIT (and MIT being more broadly adopted) and we use the hidden field to help getting people setup. github/choosealicense.com#386 has a lot of discussion about the change.

I'm sure we could modify generateLicenseMetadata to include other popular templates, based on community interest. I'd love to hear from @desktop/comrades and @desktop/engineering about this.

[shiftkey]

Dropping labels and assignees from this because #6024 is not the full solution to address this issue.

[j-f1]

How about splitting the dropdown into “recommended” and “other” sections? (Might have to reword them so they aren’t legal advice)

[say25]

I would think we could just add another line break and add the rest below