display warning message when adding folder which contains repositories

[tierninho]

re build 0.0.24, OSX 10.11.5

I added a path to a large folder on my local, when following the 'Add Repo' steps like so:

However, once adding the the path (by typing it in, not choosing folder), the following error surfaced:
The output from the command could not fit into the allocated stdout buffer. Set options.maxBuffer to a larger value than 10485760 bytes

Error continues to popup each time I select this repo in the dropdown menu.

[shiftkey]

The output from the command could not fit into the allocated stdout buffer. Set options.maxBuffer to a larger value than 10485760 bytes

This error suggests some sort of Git operation is generating out a lot of output (more than 10MB, which is impressive).

Two questions:

• what might be special about this folder that's causing the app to freak out?
• anything interesting in the console that might tell me which Git operation it is?

[tierninho]

what might be special about this folder that's causing the app to freak out?

Selected a folder with all my repos, so it's probably very big.

anything interesting in the console that might tell me which Git operation it is?

nothing was found

[shiftkey]

Selected a folder with all my repos, so it's probably very big.

Aha! Adding multiple repositories through this view wasn't supported with the classic Desktop apps - instead we expected users would drag-and-drop them onto the app. We also had the ability to use a folder without a .git subfolder as the starting point for a new repository - you'd see a different message here to indicate that's what was going to happen next.

My psychic debugger here suspects we're trying to use your user folder as a new Git repository, and git status is outputting the path to everything underneath. Will do some more testing around this flow.

cc @desktop/core for feels on what scenarios we should support here for the beta.

[shiftkey]

@niik @donokuda any UX feels here on what we should do when the user selects a path with nested Git repositories (like their home directory)?

[donokuda]

any UX feels here on what we should do when the user selects a path with nested Git repositories (like their home directory)?

I'm in favor of displaying an error saying that the folder is not a git repository if there isn't a .git folder found at the top level.

I'm also fine giving the option to turn that folder into a git repo in case that was intentional, but we should punt on that if it'll still lead to that output issue.

[joshaber]

☝️ that's how Classic/Mac behaved.

[tierninho]

This error surfaces multiple times (3x), and even after clicking it off each time, the New Repo window opens with the folder name pre-populated.

[shiftkey]

Updating this issue:

• we're not clever enough to detect when subfolders are Git repositories, so we git init the current folder when you "Create and Add" which is what the button says
• we still see the The output from the command could not fit... error afterwards, and it seems to occur periodically, which makes me think this is the result of git status (which we do periodically)
• we should prompt to understand that this isn't a git repository

[shiftkey]

Marking this as M5 because we really should handle this to avoid potential confusion.

[rlabrecque]

The "create and add" being the same operation seems silly while I understand why that decision would have been made... but they are two separate things that do two very different operations and merging them feels wrong. People look for the create repo button and this definitely causes confusion. Good to see that it's being changed.

A separate 'scan for repos' enhancement request is here: #1574