Remove GitHub AE references from Enterprise login screen#21926
Merged
sergiou87 merged 3 commits intoApr 9, 2026
Conversation
GitHub AE has been discontinued. This updates the Enterprise sign-in UI to: - Change label from 'Enterprise or AE address' to 'Enterprise address' - Update placeholder URL from https://github.example.com to https://example.ghe.com - Update the invalid URL error message with the new example URL - Update corresponding test Fixes desktop#21925 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thanks for your pull request! Unfortunately, it doesn't meet the minimum requirements for review:
Please update your PR to address the above. Requirements:
This PR will be automatically closed in 7 days if these requirements are not met. |
github-actions
Bot
added
external
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Desktop’s Enterprise sign-in UI copy to remove references to GitHub AE (now discontinued) and align the example Enterprise address shown to users.
Changes:
- Renames the Enterprise endpoint label to “Enterprise address” where applicable.
- Updates the example/placeholder Enterprise URL to
https://example.ghe.comin the Enterprise sign-in UI. - Updates the invalid-URL error message example and adjusts a unit test to match the new label.
Show a summary per file
| File | Description |
|---|---|
| app/test/unit/ui/welcome-and-sign-in-wrappers-test.tsx | Updates the Enterprise address label used by the UI test query. |
| app/src/ui/sign-in/sign-in.tsx | Updates the Enterprise endpoint placeholder to the new example URL. |
| app/src/ui/lib/enterprise-server-entry.tsx | Updates the Enterprise address label and placeholder in the Enterprise entry form component. |
| app/src/lib/stores/sign-in-store.ts | Updates the invalid URL error message example to the new placeholder URL. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sergiou87
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub AE has been discontinued. This PR updates the Enterprise sign-in UI to remove all references to it.
Changes
Enterprise or AE address→Enterprise addresshttps://github.example.com→https://example.ghe.comhttps://example.ghe.comFixes #21925