Release 2.1.2#8137
Merged
outofambit merged 5 commits intodevelopmentfrom Aug 21, 2019
Merged
Conversation
niik
added
the
ready-for-review
billygriffin
suggested changes
Aug 21, 2019
Contributor
billygriffin
left a comment
billygriffin
left a comment
There was a problem hiding this comment.
This looks good overall. There are few duplicates and the G4W upgrade wasn't for the security vulnerability this time around.
Co-Authored-By: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
After discussion with @billygriffin we've decided that we're not comfortable changing the language at this time. The feature is called suggested next steps so it feels weird to be removing the only reference to suggestions. Furthermore we feel like "in this repository" flows better than "for this repository".
billygriffin
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Preparation PR for the 2.1.2 production release which we're planning on releasing today (Aug 21).
Tasks