fix(arr): return [] on empty body; cache EventNameMap inverse#4
Merged
Merged
Conversation
Arr\{Bazarr,Prowlarr,Radarr,Sonarr}Client::get() now returns [] for empty
HTTP response bodies instead of throwing 'Invalid JSON response'. *arr
APIs legitimately return 200 OK with empty body for collection endpoints
when no rows exist (e.g. /api/v3/customformat on a fresh Radarr), which
broke every consumer of get()-based methods including CustomFormatSyncer.
post()/put()/delete() already had this guard; get() was the outlier.
EventNameMap::toAlias() now caches the inverted alias map in a private
static property instead of calling array_flip() on every invocation.
Behaviour unchanged; matters in tight-loop doc generators and debug
serialisers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 3 minor |
🟢 Metrics 0 complexity · 8 duplication
Metric Results Complexity 0 Duplication 8
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Arr\{Bazarr,Prowlarr,Radarr,Sonarr}Client::get()now returns[]for empty HTTP response bodies (matches existingpost/put/deletebehaviour). *arr APIs return 200 + empty body for collection endpoints with no rows; this brokeCustomFormatSyncerand similar consumers.EventNameMap::toAlias()caches the inverted alias map instead ofarray_flip-ing on every call.Test plan
./vendor/bin/phpunit— 164 tests, 343 assertions, all green./vendor/bin/phpstan analyze— no errors on changed files./vendor/bin/phpcs --standard=PSR12— clean