Add support for solidity structs#493
Conversation
🦋 Changeset detectedLatest commit: a55e6c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hasparus
left a comment
There was a problem hiding this comment.
Nice one! I actually asked Krzysztof about emitting struct types earlier this week, and reading this gave a better insight into TypeChain internals :)
The only comment I have is a nitpick about naming of insertStruct — have you considered registerStruct? It wasn't obvious to me what insertStruct does before reading the implementation. Feel free to disregard this comment — it's just something that's been on my mind that I wanted to mention.
The PR looks good to me.
86b454b to
eeb77fe
Compare
|
I just made the change for the name, |
08c86ea to
43457c9
Compare
e7b2ae4 to
a80965c
Compare
Example:
Closes #398