Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the GitHub Actions deploy workflow’s remote “tear down” step during Linode deployment.
Changes:
- Updates the
docker stop/docker rmtarget in the deploy script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| docker stop ghcr.io/dev-chat/muzzle:latest 2>/dev/null || true | ||
| docker rm ghcr.io/dev-chat/muzzle:latest 2>/dev/null || true |
There was a problem hiding this comment.
docker stop/docker rm expect a container name/ID, but the workflow now passes an image reference (ghcr.io/dev-chat/muzzle:latest). Since image refs can’t be container names (they include / and :), these commands will be no-ops (stderr is suppressed) and the old container may keep running, causing conflicts when start-muzzle.sh starts the new one. Use a stable container name (e.g. muzzle, matching whatever start-muzzle.sh uses) or resolve the container ID via docker ps (e.g. filter by --filter name=... or --filter ancestor="$IMAGE"). Also avoid hardcoding dev-chat; reuse the existing $IMAGE variable or ${{ github.repository_owner }} for consistency.
No description provided.