Adjusted the TRAIT_EXTRACTION_PROMPT to store traits correctly#238
Adjusted the TRAIT_EXTRACTION_PROMPT to store traits correctly#238sfreeman422 merged 18 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the TRAIT_EXTRACTION_PROMPT guidance to influence how trait strings are produced/stored by the AI trait synthesis flow in the backend.
Changes:
- Updated the output example in
TRAIT_EXTRACTION_PROMPTto remove a user identifier prefix from the sample traits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… spec type errors Agent-Logs-Url: https://github.com/dev-chat/mocker/sessions/4ef0db0a-b3f1-4118-9dbc-4620e8e94767 Co-authored-by: sfreeman422 <16405652+sfreeman422@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dev-chat/mocker/sessions/4ef0db0a-b3f1-4118-9dbc-4620e8e94767 Co-authored-by: sfreeman422 <16405652+sfreeman422@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request removes the
/traitsendpoint and its related logic from theai.controllerand associated tests, shifting trait-related responsibilities to the newTraitServiceclass. It also refactors the AI service to useTraitServicefor trait management and context generation, and updates tests accordingly. Additionally, the trait extraction prompt and output format have been simplified to remove user Slack ID references.Trait Endpoint and Test Removal:
/traitsendpoint and all related logic fromai.controller.ts, as well as associated mocks and tests fromai.controller.spec.ts. [1] [2] [3] [4] [5]Trait Service Refactor:
TraitPersistenceServicewith the newTraitServiceclass inai.service.ts, centralizing trait context generation and persistence logic. [1] [2] [3]TraitServicemethods for fetching and appending trait context, and to use the newextractParticipantSlackIdshelper.Test Updates:
ai.service.spec.tsto useTraitServicefor trait-related tests, updating mocks and test logic to reflect the new structure. [1] [2] [3] [4] [5] [6]Prompt and Output Format Simplification:
ai.constants.tsto remove references to user Slack IDs, ensuring traits are more general and privacy-conscious.