コマンドで全角スペースを使えるようにする by massongit · Pull Request #82 · dev-hato/hato-bot

massongit · 2020-05-23T15:04:24Z

@hato-bot　天気　京都 のように全角スペースを区切り文字にしたコマンドを正常にパースできるようにします。

github-actions · 2020-05-23T15:05:33Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-23T16:35:57Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)
plugins/hato.py:22:0: C0103: Constant name "space_pattern_str" doesn't conform to UPPER_CASE naming style (invalid-name)

-----------------------------------
Your code has been rated at 9.86/10

github-actions · 2020-05-23T16:39:43Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T02:04:28Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T02:12:49Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T04:22:58Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

plugins/hato.py

github-actions · 2020-05-24T05:51:31Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T06:54:25Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T06:56:52Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:12:06Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:14:50Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:29:33Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:31:43Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

This reverts commit 9c74769

github-actions · 2020-05-24T07:33:15Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:35:57Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:38:07Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T07:45:28Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T08:39:02Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:14:0: C0301: Line too long (124/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.93/10

github-actions · 2020-05-24T08:48:17Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:15:0: C0301: Line too long (124/100) (line-too-long)
plugins/hato.py:24:0: C0301: Line too long (117/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.86/10

github-actions · 2020-06-05T11:51:51Z

Lint結果だよ！🕊🕊🕊

************* Module plugins.hato
plugins/hato.py:15:0: C0301: Line too long (124/100) (line-too-long)
plugins/hato.py:24:0: C0301: Line too long (117/100) (line-too-long)

-----------------------------------
Your code has been rated at 9.85/10

Enable zenkaku space

0996a78

massongit requested a review from nakkaa May 23, 2020 15:04

massongit linked an issue May 23, 2020 that may be closed by this pull request

天気コマンドを入力した時全角スペースも対応できるようにする #80

Closed

Add var

c83d2d8

Fix var name

6fc707d

Enable heading of zenkaku space

11e982a

Separate process to function

8506fbf

Use respond_to_with_space

4d8791f

Goryudyuma reviewed May 24, 2020

View reviewed changes

plugins/hato.py Outdated Show resolved Hide resolved

plugins/hato.py Outdated Show resolved Hide resolved

plugins/hato.py Outdated Show resolved Hide resolved

Add type hint

a032ea6

massongit added 2 commits May 24, 2020 15:52

Fix parameter

4c60345

Add test

b41147e

github-actions bot mentioned this pull request May 24, 2020

formatが間違ってたので直してあげたよ！PRをマージしてね！ #82 #87

Closed

Fix

72e8399

Add test

169ec3d

github-actions bot mentioned this pull request May 24, 2020

formatが間違ってたので直してあげたよ！PRをマージしてね！ #82 #88

Closed

Fix

828c843

github-actions bot mentioned this pull request May 24, 2020

formatが間違ってたので直してあげたよ！PRをマージしてね！ #82 #89

Closed

add -v

9c74769

add __init__.py

fe903ce

Revert "add -v"

7074e50

This reverts commit 9c74769

Fix format

1ae1140

Add process to set .env

2eddf2c

massongit added 2 commits May 24, 2020 17:37

Simplify

3e84220

Add test

bf6d776

Add type hints

be53e60

massongit requested a review from Goryudyuma May 24, 2020 10:22

Merge branch 'develop' into enable_zenkaku_space

b173207

nakkaa merged commit 7a3f9d3 into develop Jun 5, 2020

nakkaa deleted the enable_zenkaku_space branch June 5, 2020 11:54

Conversation

massongit commented May 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 23, 2020

Uh oh!

github-actions bot commented May 23, 2020

Uh oh!

github-actions bot commented May 23, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented May 24, 2020

Uh oh!

github-actions bot commented Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

massongit commented May 23, 2020 •

edited

Loading