Skip to content

型ヒントのチェック用CI追加#90

Merged
nakkaa merged 14 commits intodevelopfrom
add_mypy
Jun 5, 2020
Merged

型ヒントのチェック用CI追加#90
nakkaa merged 14 commits intodevelopfrom
add_mypy

Conversation

@massongit
Copy link
Copy Markdown
Member

@massongit massongit commented May 24, 2020

型ヒントのチェック用のCIを追加します。
また、型ヒントのチェックやlintで怒られている箇所を修正しています。

@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:47:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)
create_env.py:29:4: C0103: Argument name "SQL" doesn't conform to snake_case naming style (invalid-name)
create_env.py:29:4: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:35:12: W0702: No exception type(s) specified (bare-except)
create_env.py:42:0: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:43:32: C0103: Variable name "db" doesn't conform to snake_case naming style (invalid-name)
create_env.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 7.33/10

@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:47:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)
create_env.py:29:4: C0103: Argument name "SQL" doesn't conform to snake_case naming style (invalid-name)
create_env.py:29:4: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:35:12: W0702: No exception type(s) specified (bare-except)
create_env.py:42:0: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:43:32: C0103: Variable name "db" doesn't conform to snake_case naming style (invalid-name)
create_env.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 7.33/10

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:47:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)
create_env.py:29:4: C0103: Argument name "SQL" doesn't conform to snake_case naming style (invalid-name)
create_env.py:29:4: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:35:12: W0702: No exception type(s) specified (bare-except)
create_env.py:42:0: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:43:32: C0103: Variable name "db" doesn't conform to snake_case naming style (invalid-name)
create_env.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 7.33/10

@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:49:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)
create_env.py:37:12: W0702: No exception type(s) specified (bare-except)
create_env.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:45:32: C0103: Variable name "db" doesn't conform to snake_case naming style (invalid-name)
create_env.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 8.00/10

@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:50:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)
create_env.py:37:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
create_env.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)
create_env.py:46:32: C0103: Variable name "db" doesn't conform to snake_case naming style (invalid-name)
create_env.py:53:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 8.06/10

@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:52:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)

-----------------------------------
Your code has been rated at 9.35/10

@massongit massongit changed the title pr-testに型ヒントのチェック追加 型ヒントのチェック用CI追加 May 24, 2020
@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:52:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)

-----------------------------------
Your code has been rated at 9.35/10

@github-actions
Copy link
Copy Markdown
Contributor

Lint結果だよ!🕊🕊🕊

************* Module create_env
create_env.py:52:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)

-----------------------------------
Your code has been rated at 9.35/10

@massongit massongit requested review from Goryudyuma and nakkaa May 24, 2020 10:20
@massongit massongit removed the request for review from nakkaa May 24, 2020 12:32
@nakkaa nakkaa merged commit a574c76 into develop Jun 5, 2020
@nakkaa nakkaa deleted the add_mypy branch June 5, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants