Skip to content

Add favicon to public directory#20

Merged
vinzvinci merged 1 commit intodev-protocol:mainfrom
anatxiki:main
Oct 7, 2021
Merged

Add favicon to public directory#20
vinzvinci merged 1 commit intodev-protocol:mainfrom
anatxiki:main

Conversation

@anatxiki
Copy link
Copy Markdown
Contributor

@anatxiki anatxiki commented Oct 6, 2021

Fixes #19

Objective

Adding favicon.ico to the public repository.

Notes

I have not deleted the original logo.png in case it is needed.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 6, 2021

✔️ Deploy Preview for devprotocol ready!

🔨 Explore the source changes: 803fe0b

🔍 Inspect the deploy log: https://app.netlify.com/sites/devprotocol/deploys/615de052faf0a80008f9bc35

😎 Browse the preview: https://deploy-preview-20--devprotocol.netlify.app

@Panquesito7 Panquesito7 added the enhancement New feature or request label Oct 6, 2021
Copy link
Copy Markdown
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@anatxiki
Copy link
Copy Markdown
Contributor Author

anatxiki commented Oct 6, 2021

Thank you for the opportunity!

@Panquesito7 Panquesito7 linked an issue Oct 6, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vinzvinci vinzvinci added the hacktoberfest-accepted This PR is valid and approved by the maintainers label Oct 7, 2021
@vinzvinci vinzvinci merged commit 12c9984 into dev-protocol:main Oct 7, 2021
Copy link
Copy Markdown

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not perfect.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hacktoberfest hacktoberfest-accepted This PR is valid and approved by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a favicon

5 participants