efi-check should run on remote host, not locally#103
Merged
chris-rock merged 1 commit intodev-sec:masterfrom Sep 4, 2018
Merged
efi-check should run on remote host, not locally#103chris-rock merged 1 commit intodev-sec:masterfrom
chris-rock merged 1 commit intodev-sec:masterfrom
Conversation
chris-rock
reviewed
Sep 3, 2018
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Thank you @rndmh3ro Great finding!
| # if efi is active, do not disable vfat. otherwise the system | ||
| # won't boot anymore | ||
| unless Dir.exist?('/sys/firmware/efi') | ||
| unless efi_dir.exist? |
Member
There was a problem hiding this comment.
I think we can just write unless file('/sys/firmware/efi').exist?
Member
Author
There was a problem hiding this comment.
I tried that but got the following error message:
~/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.8.0/lib/rspec/core/example_group.rb:726:in `method_missing': `file` is not available on an example group (e.g. a `describe` or `context` block).It is only available from within individual examples (e.g. `it` blocks) or from constructs that run in the scope of an example (e.g. `before`, `let`, etc). (RSpec::Core::ExampleGroup::WrongScopeError)
Member
There was a problem hiding this comment.
Alright, lets go with that approach for now. Thank you @rndmh3ro
chris-rock
approved these changes
Sep 4, 2018
Member
chris-rock
left a comment
chris-rock
left a comment
There was a problem hiding this comment.
Thank you @rndmh3ro for this improvement
| # if efi is active, do not disable vfat. otherwise the system | ||
| # won't boot anymore | ||
| unless Dir.exist?('/sys/firmware/efi') | ||
| unless efi_dir.exist? |
Member
There was a problem hiding this comment.
Alright, lets go with that approach for now. Thank you @rndmh3ro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.