Fixing some deprecation notices#119
Merged
chris-rock merged 1 commit intodev-sec:masterfrom Sep 19, 2019
jjasghar:jjasghar/deprication
Merged
Fixing some deprecation notices#119chris-rock merged 1 commit intodev-sec:masterfrom jjasghar:jjasghar/deprication
chris-rock merged 1 commit intodev-sec:masterfrom
jjasghar:jjasghar/deprication
Conversation
`default` is being replaced by `value` Signed-off-by: JJ Asghar <awesome@ibm.com> Signed-off-by: JJ Asghar <jjasghar@gmail.com>
Member
|
@jjasghar thanks for this PR! Is this change backward compatible to inspec 3? We have to maintain support of inspec 3 for a while. |
Member
|
@artem-sidorenko I just double-checked it yesterday for /pull/119 The use of value is fine as long as we update the minimum InSpec version to 3.4.1 in the readme (see https://github.com/inspec/inspec/blob/95ed2696e98181133cc586797d90e1ff777f79a4/CHANGELOG.md#v341-2019-01-29) |
artem-sidorenko
approved these changes
Jul 17, 2019
Member
|
@chris-rock thanks! |
Member
|
@chris-rock we do not have any inspec version in the README here, should we just merge this PR? |
Member
|
Yes, we can. I think we should mention somewhere that we aim to stay InSpec 3 compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultis being replaced byvalue