Skip to content

Do not disable vfat by default #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artem-sidorenko merged 1 commit into from
Jul 16, 2018
Merged

Do not disable vfat by default #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion controls/os_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,11 @@
its(:content) { should match 'install hfsplus /bin/true' }
its(:content) { should match 'install squashfs /bin/true' }
its(:content) { should match 'install udf /bin/true' }
its(:content) { should match 'install vfat /bin/true' }
# if efi is active, do not disable vfat. otherwise the system
# won't boot anymore
unless Dir.exist?('/sys/firmware/efi')
Copy link
Copy Markdown
Member

@artem-sidorenko artem-sidorenko Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rndmh3ro maybe we have a bug here. Dir.exist? gets executed in the local context and not on the remote system. We should do this check via inspec resources

Copy link
Copy Markdown
Member Author

@rndmh3ro rndmh3ro Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh okay, I did not know this... I'll have to take a look.

its(:content) { should match 'install vfat /bin/true' }
end
end
end

Expand Down