Merged
Conversation
Member
|
Thanks |
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
implemented for ubuntu right now Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
1. the user configuration and options should be handled in the recipe/module. leaving these options in is nice, but not very maintainable since it may prevent us from using upstream modules/cookbooks for ssh management, which may not all have the option to add comments. since it's unnecessary, remove it 2. none of these commented options requires being set by compliance guidelines and sanity, so imho they are all fine to be removed Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
implemented for ubuntu right now Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
implemented for ubuntu right now Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, please see the issue that tracks the supported ciphers: #4
This closes #4
This also closes #5