Skip to content

Support Amazon Linux#97

Merged
artem-sidorenko merged 1 commit intodev-sec:masterfrom
woneill:amazon_linux
Jan 11, 2018
Merged

Support Amazon Linux#97
artem-sidorenko merged 1 commit intodev-sec:masterfrom
woneill:amazon_linux

Conversation

@woneill
Copy link
Copy Markdown
Contributor

@woneill woneill commented Jan 4, 2018

No description provided.

ciphers = ciphers66
end
when 'fedora'
when 'amazon', 'fedora'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woneill thanks for your PR! Sure its fedoraand not redhat?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the redhat family but since it uses a newer kernel and packages than redhat 6 I figured it'd be more accurate to have it use the fedora case matchers.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woneill does the check for inspec.os[:release]not cover the newer kernel/packages? I always thought that current amazon linux is based on RHEL 7, is it not the case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a weird mix of RHEL 6 and 7 features. For instance, the package versions appear to be similar to RHEL 7 releases but it doesn't use systemd. Also inspec.os[:release] returns a date-like value such as 2017.09.

== Operating System Details

Name:      amazon
Family:    redhat
Release:   2017.09
Arch:      x86_64

Copy link
Copy Markdown
Member

@artem-sidorenko artem-sidorenko Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woneill sounds reasonable, thanks for explaining it!

Copy link
Copy Markdown
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-rock @atomic111 any remarks?

@artem-sidorenko artem-sidorenko merged commit 9f4adb2 into dev-sec:master Jan 11, 2018
@artem-sidorenko
Copy link
Copy Markdown
Member

@woneill thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants