test(scan-gaps): graduate cell_range subrectangle test (P1-5)#30
Open
dev360 wants to merge 1 commit into
Open
Conversation
``Locate.cell_range`` was already wired through ``_read_flat_grid`` (see ``min_row`` / ``max_row`` / ``min_col`` / ``max_col`` derivation) but the proposed acceptance test had been carrying an ``xfail(strict=True)`` since the field-scan corpus landed because no one had actually re-verified the end-to-end behavior. Removing the marker (with the matching ``description:`` add the template loader requires) turns the existing wiring into a real acceptance check: two entities with disjoint cell_range values on the same tab each see only their own subrectangle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dev360
force-pushed
the
feat/p1-5-cell-range
branch
from
e8d02b6 to
7e0fd87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes P1-5. The brief noted "investigation first; the field exists, may already work" — and it does.
Locate.cell_rangealready gates row/column extraction in_read_flat_grid:No code change needed. This PR just removes the
xfail(strict=True)marker on the proposed acceptance test so the existing wiring becomes a real regression check: two entities with disjointcell_rangevalues on the same tab each see only their own subrectangle.Test plan
uv run pytest tests/test_field_scan_gaps.py::test_cell_range_restricts_extraction_to_subrectangle -v— passes.uv run pytest -q— 105 passed, 36 xfailed.uvx --from 'ruff==0.6.9' ruff check .andruff format --check .— clean.🤖 Generated with Claude Code