Skip to content

Add chapter on assembly and python#29

Merged
jonasgeiler merged 4 commits intodevRant-Community:masterfrom
gadilashashank:master
Jun 4, 2018
Merged

Add chapter on assembly and python#29
jonasgeiler merged 4 commits intodevRant-Community:masterfrom
gadilashashank:master

Conversation

@gadilashashank
Copy link
Copy Markdown
Member

Major fuck up in previous pull.

@gadilashashank gadilashashank requested a review from a team May 28, 2018 17:43
@gadilashashank gadilashashank added the new-part This PR adds a new entire language chapter or only a part of it. label May 28, 2018
@gadilashashank
Copy link
Copy Markdown
Member Author

Cleaned commit tree.

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/book/languages/python/intro.md
  4:81 no-trailing-spaces [MD009] Trailing spaces [Expected: 0; Actual: 1]
  5:85 no-trailing-spaces [MD009] Trailing spaces [Expected: 0; Actual: 1]

Please fix these errors before merging!

1 similar comment
@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/book/languages/python/intro.md
  4:81 no-trailing-spaces [MD009] Trailing spaces [Expected: 0; Actual: 1]
  5:85 no-trailing-spaces [MD009] Trailing spaces [Expected: 0; Actual: 1]

Please fix these errors before merging!

@gadilashashank
Copy link
Copy Markdown
Member Author

@skayo thanks for the commas and quotes. I don't understand the difference between the ones used by you and me but let them stay

@jonasgeiler
Copy link
Copy Markdown
Member

jonasgeiler commented May 28, 2018

(Sorry for doing a lot of commits, cannot amend in web version)
I fixed the

  • quotes (Use “” instead of ""; more book-likely)
  • grammar (What I found)
  • typos (Found a few)

I didn't check structure or general spelling (sentences).
Would need help from @devRant-Community/editors there.

@gadilashashank
Copy link
Copy Markdown
Member Author

@skayo if you haven't noticed I'm a part of the editing team :) anyways I'm welcome for suggestions..

@jonasgeiler jonasgeiler merged commit 1cdff47 into devRant-Community:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-part This PR adds a new entire language chapter or only a part of it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants