Skip to content

Modify badge links and remove poll#32

Merged
gadilashashank merged 1 commit intodevRant-Community:masterfrom
gadilashashank:master
Jun 14, 2018
Merged

Modify badge links and remove poll#32
gadilashashank merged 1 commit intodevRant-Community:masterfrom
gadilashashank:master

Conversation

@gadilashashank
Copy link
Copy Markdown
Member

Title says all. Changed "devRant-Squad" in all links to "devRant-Community" to get the badges working again and since the title is decided to "A Ginormous..." the poll has also been removed.

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/README.md
  1 blanks-around-headings [MD022] Headings should be surrounded by blank lines "# Community-Programming-Book"
  2:301 line-length [MD013] Line length [Expected: 300; Actual: 394]
  2:1 no-inline-html [MD033] Inline HTML [Element: a]

Please fix these errors before merging!

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/README.md
  3:1 no-inline-html [MD033] Inline HTML [Element: a]
  4:1 no-inline-html [MD033] Inline HTML [Element: a]

Please fix these errors before merging!

@gadilashashank
Copy link
Copy Markdown
Member Author

@skayo can you modify that inline html rule?

@jonasgeiler
Copy link
Copy Markdown
Member

just ignore it i guess

@jonasgeiler
Copy link
Copy Markdown
Member

can't modify for a single file

@gadilashashank
Copy link
Copy Markdown
Member Author

gadilashashank commented Jun 14, 2018

@skayo shall I merge it?

@jonasgeiler
Copy link
Copy Markdown
Member

No wait just add this to the beginning of the README:
<!-- markdownlint-disable MD033 -->

@jonasgeiler
Copy link
Copy Markdown
Member

Should work.

@gadilashashank
Copy link
Copy Markdown
Member Author

gadilashashank commented Jun 14, 2018

Adding and merging if build passes

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/README.md
  1 blanks-around-headings [MD022] Headings should be surrounded by blank lines "# Community-Programming-Book"

Please fix these errors before merging!

@jonasgeiler
Copy link
Copy Markdown
Member

looks good. Now just add a newline after the header

@gadilashashank gadilashashank merged commit c874c6e into devRant-Community:master Jun 14, 2018
@gadilashashank
Copy link
Copy Markdown
Member Author

Yay closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants