Skip to content

working on Golang part,#39

Merged
gadilashashank merged 10 commits intodevRant-Community:masterfrom
unrooted:master
Jul 3, 2018
Merged

working on Golang part,#39
gadilashashank merged 10 commits intodevRant-Community:masterfrom
unrooted:master

Conversation

@unrooted
Copy link
Copy Markdown
Contributor

I'll add text to misc.md, disadvantages.md and conclusion.md soon, a request: check grammar in files that I added.

…clusion.md soon, request: check grammar in files that I added.
@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/book/languages/golang/advantages.md
  1 first-heading-h1 [MD002] First heading should be a top level heading [Expected: h1; Actual: h2]
  1:24 no-trailing-punctuation [MD026] Trailing punctuation in heading [Punctuation: '.']
  1 first-line-h1 [MD041] First line in file should be a top level heading "## Advantages of Golang."
devRant-Community/Community-Programming-Book/book/languages/golang/history.md
  3:92 no-trailing-punctuation [MD026] Trailing punctuation in heading [Punctuation: '.']
  21:14 no-trailing-punctuation [MD026] Trailing punctuation in heading [Punctuation: '.']
devRant-Community/Community-Programming-Book/book/languages/golang/README.md
  1:11 no-trailing-punctuation [MD026] Trailing punctuation in heading [Punctuation: '!']

Please fix these errors before merging!

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/book/languages/golang/advantages.md
  5:117 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]
  8:106 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]
  17:118 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]

Please fix these errors before merging!

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/book/languages/golang/advantages.md
  5:117 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]
  8:106 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]
  17:118 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]

Please fix these errors before merging!

@jonasgeiler-bot
Copy link
Copy Markdown

Checks failed - mdlint output:

devRant-Community/Community-Programming-Book/book/languages/golang/advantages.md
  8:106 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]
  17:118 no-trailing-spaces [MD009] Trailing spaces [Expected: 0 or 2; Actual: 1]

Please fix these errors before merging!

@gadilashashank
Copy link
Copy Markdown
Member

@RootPixl requesting the review of the editing team was sufficient so I removed the others

Copy link
Copy Markdown
Member

@gadilashashank gadilashashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits have been made.The change that request is that intro.md file needs to be completely re-written because for one there are several other things that can be written to introduce a language. Other than that everything is fine. Ask for any help if needed.

…es.md, misc.md (with code examples) and conclusion.md
@unrooted
Copy link
Copy Markdown
Contributor Author

@gadilashashank check it out.

Copy link
Copy Markdown
Member

@gadilashashank gadilashashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intro.md possibly needs a re-write. Otherwise everything is fine for a merge

@gadilashashank
Copy link
Copy Markdown
Member

Thanks for changing the intro. I'll once again go through the content and merge it.

@gadilashashank gadilashashank merged commit 32cb77f into devRant-Community:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants