Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the project to v1.5.3 and aims to improve duty-leave constraint error detection/handling in the attendance UI, while also enhancing container signing metadata and adding Cosign verification documentation.
Changes:
- Expanded
isDutyLeaveConstraintErrorto detect constraint violations via nested error structures and message fallback, with accompanying tests. - Adjusted
AddAttendanceDialogto avoid logging/reporting expected duty-leave constraint violations. - Added Cosign verification documentation, added Cosign signature annotations in CI workflows, and bumped versions across docs/manifests.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/lib/error-handling.ts |
Adds broader detection logic for duty-leave constraint errors (direct/nested/message). |
src/lib/__tests__/duty-leave-error-handling.test.ts |
Adds tests for new nested/message detection paths. |
src/components/attendance/AddAttendanceDialog.tsx |
Avoids logging/Sentry reporting for expected business-constraint errors. |
public/api-docs/openapi.yaml |
Bumps API version to 1.5.3. |
package.json |
Bumps app version to 1.5.3. |
package-lock.json |
Updates lockfile version fields to 1.5.3. |
docs/COSIGN_VERIFICATION.md |
Adds guidance for verifying Cosign signatures/attestations. |
.github/workflows/release.yml |
Removes COSIGN_EXPERIMENTAL and adds Cosign signature annotations. |
.github/workflows/pipeline.yml |
Removes COSIGN_EXPERIMENTAL and adds Cosign signature annotations. |
.example.env |
Updates NEXT_PUBLIC_APP_VERSION to 1.5.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
…347) * Initial plan * fix: improve type safety and error handling in isDutyLeaveConstraintError Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>
devakesu-admin
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: enhance error handling in AddAttendanceDialog