fix: restore release.yml and remove secrets.IMAGE_NAME to fix output secret warning#445
fix: restore release.yml and remove secrets.IMAGE_NAME to fix output secret warning#445
Conversation
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>
|
@copilot Will it fix |
…output warning Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>
The Fixed in ba1ec71 by moving the |
|
@copilot Nope, the issue persisted before I added mask. |
…ectly Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR restores the complete release.yml workflow that was accidentally replaced with a stub in commit 258452f, and fixes a GitHub Actions warning by removing secrets.IMAGE_NAME from the workflow. The image name is now derived directly from github.repository (the repository name lowercased), which is the same fallback logic already used throughout the workflow.
Changes:
- Restored the full 754-line
release.ymlworkflow from the broken 7-line stub - Removed
secrets.IMAGE_NAMEfrom the "Prepare derived values" step to fix "Skip output 'image_name' since it may contain secret" warning - Image name is now always derived from
github.repositoryusing the same transformation logic present in downstream fallbacks
…secret warning (#445) * Initial plan * fix: restore release.yml and fix IMAGE_NAME output warning with printf Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> * fix: write image_name to GITHUB_OUTPUT before masking to fix skipped output warning Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> * fix: remove secrets.IMAGE_NAME — derive image name from repo name directly Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>
* chore: update dependencies and improve Dockerfile npm installation process, refine few lines, update supabase workflow * Update .github/workflows/deploy-supabase.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Devanarayanan <fusion@devakesu.com> * Update line 238 in release.yml to format IMAGE_NAME correctly * fix: restore release.yml and remove secrets.IMAGE_NAME to fix output secret warning (#445) * Initial plan * fix: restore release.yml and fix IMAGE_NAME output warning with printf Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> * fix: write image_name to GITHUB_OUTPUT before masking to fix skipped output warning Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> * fix: remove secrets.IMAGE_NAME — derive image name from repo name directly Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com> * Update eslint-config-next and typescript-eslint versions Signed-off-by: Devanarayanan <fusion@devakesu.com> --------- Signed-off-by: Devanarayanan <fusion@devakesu.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Pull Request
Description
Previous commit (
258452f) accidentally replaced the entire 754-linerelease.ymlwith a stub. Restores the full workflow and fixes the GitHub Actions warning "Skip output 'image_name' since it may contain secret."Root cause:
IMAGE_NAME_SECRET: ${{ secrets.IMAGE_NAME }}— GitHub Actions automatically masks all secret values. When a secret-derived value is written to$GITHUB_OUTPUT, GitHub Actions detects it and skips the output entirely. This occurs regardless of masking order or shell tricks likeprintf '%s'.Fix: Remove
secrets.IMAGE_NAMEfrom the step entirely. The image name is derived directly fromgithub.repository(the same fallback logic already present in the step and used in all downstream jobs), eliminating any secret involvement and the warning at its root.Type of Change
Changes Made
release.ymlto its full 754-line state (reverted broken stub from258452f)secrets.IMAGE_NAMEfrom the "Prepare derived values" step and the::add-mask::call; image name is now always derived fromgithub.repository(lowercased repo name), matching the existing fallback used throughout the workflowVersion Bump
node scripts/bump-version.js(fork PRs)Testing
Test Environment
Tests Performed
npm run test)npm run test:e2e)npm run lint)Test Coverage
Workflow syntax verified. Deriving the image name from
github.repositoryis consistent with the fallback logic already used in the build and downstream verify/deploy jobs, so no behavior change occurs for this repository.Documentation
Checklist
Screenshots (if applicable)
N/A
Additional Notes
GitHub Actions automatically masks every value injected via the
secretscontext. Any step that writes a masked value to$GITHUB_OUTPUTwill have that output silently skipped with the "Skip output since it may contain secret" warning — regardless of ordering or encoding tricks. The only reliable fix is to avoid using a secret as the source of the value. Since the image name is not sensitive, removing it from secrets and deriving it from the repository context is the correct solution.For maintainers:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.