fix(pwa,tracking): extract clearState helper, consolidate depth counter into navDepthRef, fix Tailwind utilities

[Copilot]

Pull Request

Description

Addresses unresolved review comments from PR #582. Fixes unreliable history.length-based deep-back detection in useBackToExit, eliminates duplicated ref-reset logic across toast callbacks, and corrects two non-standard Tailwind utility classes in TrackingClient.

useBackToExit.ts — clearState() helper

onDismiss/onAutoClose previously inlined the same 5-ref reset already in resetExitState(). Extracted clearState() — resets exit-state refs without calling toast.dismiss() (avoids re-entrant dismissals). resetExitState() now calls toast.dismiss() + clearState(); the toast callbacks reference clearState directly.

// Before: 5-line inline block duplicated in onDismiss AND onAutoClose
onDismiss: () => {
  toastIdRef.current = null;
  firstBackTimeRef.current = null;
  nonDashboardBackCountRef.current = 0;
  exitArmedRef.current = false;
  exitModeRef.current = null;
},

// After: single shared helper
const clearState = () => { /* resets refs including navDepthRef, no toast.dismiss() */ };
const resetExitState = () => { toast.dismiss(toastIdRef.current); clearState(); };
// ...
onDismiss: clearState,
onAutoClose: clearState,

useBackToExit.ts — navDepthRef replaces both history.length and nonDashboardBackCountRef

history.length is a session-wide counter that never decreases on back navigation, causing misclassification of shallow positions as "deep". Replaced with navDepthRef — a hook-internal counter that serves as the single source of truth for qualifying non-dashboard back presses. The separate nonDashboardBackCountRef has been removed; navDepthRef now drives both depth tracking and the >= 2 deep-mode toast gate.

Key semantics:

• Incremented after any resetExitState() branches so each new sequence starts at 1
• Included in clearState() so toast expiry/dismiss resets the count, requiring a fresh 2-press sequence
• Reset to 0 on sentinel hit, dashboard route visit, and deep-mode close

TrackingClient.tsx — Tailwind utility fixes

• backdrop-blur-xs → backdrop-blur-sm (no xs blur in Tailwind's default scale)
• top-22 → top-[88px] (no 22 in Tailwind's default spacing scale)

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code refactoring
• Performance improvement
• Test updates

Related Issues

Relates to #582

Changes Made

• Extracted clearState() helper inside useEffect; onDismiss/onAutoClose now reference it instead of duplicating inline reset blocks
• Removed nonDashboardBackCountRef; consolidated into navDepthRef as the single qualifying-back-press counter
• navDepthRef added to clearState() so toast expiry resets the count; incremented after resetExitState() branches so sequences always start at 1
• navDepthRef.current >= 2 gates the deep-mode exit toast (replaces nonDashboardBackCountRef.current >= 2)
• backdrop-blur-xs → backdrop-blur-sm and top-22 → top-[88px] in TrackingClient.tsx
• Removed now-irrelevant history.pushState setups from tests that only existed to inflate history.length; updated affected test description

Version Bump

• Version automatically bumped by workflow (same-repo PRs)
• Version manually bumped using node scripts/bump-version.js (fork PRs)
• Version already up-to-date (no bump needed)

Testing

Test Environment

• Node version: 22
• npm version: 10
• OS: Linux

Tests Performed

• Unit tests pass (npm run test)
• E2E tests pass (npm run test:e2e)
• Linting passes (npm run lint)
• Manual testing completed

Test Coverage

All 20 useBackToExit unit tests pass. Tests updated to reflect that depth tracking no longer depends on history.length and that the single navDepthRef counter drives the deep-mode gate.

Documentation

• Documentation updated (if needed)
• Code comments added for complex logic
• API documentation updated (if API changes)

Checklist

• My code follows the project's code style
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings or errors
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

navDepthRef is now the single counter for both "how deep has the user navigated?" and "how many qualifying back presses have occurred in this sequence?". It resets in clearState() on toast expiry/dismiss so the user must press back twice again for a fresh deep-mode trigger, and resets to 0 at sentinel/dashboard/close so deep-mode counting always restarts cleanly from a root or shallow position.

---

For maintainers:

• PR title follows conventional commit format
• Version bump is correct
• All checks pass
• Documentation is complete
• Ready to merge

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

Refactors and fixes the standalone-PWA “double back to exit” behavior and cleans up tracking UI styling, primarily addressing follow-up items from PR #582.

Changes:

• Extracts a shared clearState() helper in useBackToExit to dedupe toast-dismiss reset logic.
• Replaces the previous history.length-based deep/back detection approach with a hook-internal depth ref (navDepthRef) and updates tests accordingly.
• Fixes non-standard Tailwind utility classes used in the tracking client UI.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/hooks/useBackToExit.ts	Refactors exit-state resets and changes deep/back detection logic for standalone PWA behavior.
src/hooks/tests/useBackToExit.test.ts	Updates unit tests to align with the new depth/back detection approach.
src/app/(protected)/tracking/TrackingClient.tsx	Replaces invalid Tailwind utilities with supported/default/arbitrary equivalents.
package-lock.json	Updates lockfile after dependency resolution changes during install.

[Copilot]

navDepthRef is incremented here but never read to make any decision (it only ever gets reset). That means the previous “deep history” gating was effectively removed, and the new counter currently doesn’t influence when the deep-mode exit flow should apply. Either wire navDepthRef into the deep/back detection logic (and/or replace nonDashboardBackCountRef), or remove it to avoid misleading depth-tracking semantics.

[devakesu]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Fixed in b61fc5a. Removed nonDashboardBackCountRef entirely and consolidated it into navDepthRef:

• navDepthRef.current = 0 added to clearState() — toast expiry/dismiss resets the count, requiring a fresh 2-press sequence
• navDepthRef.current += 1 moved to after all resetExitState() branches, so the count correctly starts at 1 in each new sequence (not counting the press that triggers a reset)
• navDepthRef.current >= 2 now drives the deep-mode toast gate
• Redundant explicit depth resets removed (all handled by clearState() inside resetExitState())