Optional high-memory bootloader #24
Conversation
|
These changes look pretty good to me from just reading the code. There are some minor typos and additional comments for the linker scripts that I'd eventually like to adjust, but otherwise I don't think this will need any major functional changes. When I get a chance, I will do some sanity testing on this branch with my dev boards. |
|
Hi!
Just comment the patch here and I can fix the typos and add the comments.
Today I also plan to test on bluepill and olimexino-stm32. Have Fun! |
devanlai
left a comment
devanlai
left a comment
There was a problem hiding this comment.
These changes look good to me. I've completed my testing on the bluepill and stlink/v2 clone boards and I'm satisfied that everything works as it should. I did some cursory testing with the maple-mini since I didn't have any good test programs lying around, but I'm fairly confident that since it worked for the bluepill and stlink, it will be fine for the maple-mini.
I've left my comments on some minor nits. You can address them if you'd like, but I'm fine with making those nitpick fixes on my own after merging as-is too. I'll be making some other general changes to fix minor build deficiencies soon anyways.
Adds a compilation define `BOOTLOADER_HIGH` that compiles a high-memory version of the bootloader. The high-memory bootloader lives at the high end of flash, allowing an non- bootloader-aware application to run without modifications. The bootloader modifies the application's vector table to point to the bootloader's reset stub. The actual reset vector is stored in unused entries in the application's vector table. Based on ideas from: http://stm32duino.com/viewtopic.php?t=687 This is based on code from commit cf21dc3 fixing DFU upload and rebasing on current master branch. Co-authored-by: Devan Lai <devan.lai@gmail.com>
|
Hi! Pushed new version. Thanks! |
|
Thanks, I've merged your changes. Great work! |
2 participants
This is my current patch for the option 2 as discussed on pull-request #23
I have not tested all the options, so do not merge yet.