fix(ci): release revert commits so reverts reach the cluster#76
Merged
Conversation
The revert #75 (dropping the panic-on-create CodeRabbit ruleset) merged to main but semantic-release reported "no release": the default release rules cover feat/fix/perf but not the `revert` type, so the deploy/ change was never published — the github-config OCI artifact stayed at v1.8.0 (which still contains the broken ruleset) and the failing OrganizationRuleset CR was never pruned. Add a commit-analyzer releaseRule mapping `revert` -> patch so revert commits cut a release (and reach the cluster). This `fix:` commit itself triggers the patch that republishes current main — with #75's removal already applied. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesSemantic Release Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The revert #75 (dropping the panic-on-create CodeRabbit ruleset) merged to main but never deployed. semantic-release reported:
The repo's
.releasercuses@semantic-release/commit-analyzerwith default rules only (feat/fix/perf) — thereverttype isn't covered. So no tag was cut,cd.yamlnever re-published, and the github-config OCI artifact stayed at v1.8.0 (which still contains the broken ruleset). The failingOrganizationRulesetCR is therefore still on-cluster and un-pruned.This is a latent bug: any
revert(...)PR would silently fail to deploy.Fix
Add a
commit-analyzerreleaseRulemappingrevert→patch, so revert commits cut a release. Two effects:fix:commit (a default release rule) cuts a patch now →cd.yamlrepublishes current main, which already has revert(rulesets): drop the provider-uncreatable CodeRabbit required-check ruleset #75's removal applied → Flux prunes the failing CR.revert(...)commits will release, so a revert always reaches the cluster.Validated:
.releasercis valid JSON;revert→patch added without dropping the default feat/fix/perf rules.🤖 Generated with Claude Code
Summary by CodeRabbit