ci: grant release-please the workflows scope for self-pin rewrites#337
Merged
Conversation
Code Coverage OverviewLanguages: Go, C# Go / code-coverage/testThe overall coverage remains at 50%, unchanged from the branch. C# / code-coverage/dotnetThe overall coverage remains at 100%, unchanged from the branch. Updated |
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
The 🎉 Release workflow rewrites the x-release-please-version self-pins listed in release-please extra-files; five of those targets live under .github/workflows/. The botantler-1 App token requested only contents/ pull-requests/issues, so writing a workflow file was rejected (403, surfaced by release-please as the opaque "Error adding to tree") — wedging the release pipeline on every releasable commit since #314. The botantler-1 App holds the Workflows repository permission (read+write), so request it on the token (permission-workflows: write). This preserves the documented convention that release-please owns the first-party self-pins, rather than dropping the workflow files from extra-files.
c825818 to
eb26496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem — releases were wedged on
mainThe
🎉 Releaseworkflow failed on every push since #314 (feat!: merge reusable-workflows into the actions repo) with the opaquerelease-please failed: Error adding to tree. No GitHub release/tag could be cut.Root cause
release-pleaserewrites the# x-release-please-versionself-pins listed inextra-files. Five of those targets live under.github/workflows/. The🎉 Releaseworkflow mints a botantler-1 App token that requested onlycontents/pull-requests/issues— notworkflows— so writing any file under.github/workflows/returned403 Resource not accessible by integration, which release-please surfaces as the opaque "Error adding to tree" (release-please-action#938).feat!(#314) was simply the first releasable commit to actually exercise the workflow-file rewrite.Fix
The botantler-1 App holds the Workflows repository permission (read+write), so request it on the token:
permission-contents: write permission-pull-requests: write permission-issues: write + permission-workflows: writeThis preserves the documented convention that release-please owns the first-party self-pins (no change to
release-please-config.json), rather than dropping the workflow files fromextra-files.Validation
actionlintclean onactive-release.yaml; net diff is the singlepermission-workflows: writeline (+ explanatory comment).[Test] Create Release - Dry Run / Releasecheck exercises release-please against this config.Net diff: +3 lines in
.github/workflows/active-release.yaml, nothing else.