feat(vpa): enable InPlaceOrRecreate feature gate for updater and admissionController#1291
Merged
botantler[bot] merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-project-automation
bot
moved this from 🫴 Ready
to 🚀 In Finalization
in 🌊 Project Board
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the VPA InPlaceOrRecreate behavior by re-introducing the InPlaceOrRecreate feature gate for the standalone Vertical Pod Autoscaler HelmRelease (after VPA was separated out from the Goldilocks sub-chart), and fixes the referenced upstream values URL comment.
Changes:
- Add
extraArgs.feature-gates: InPlaceOrRecreate=truefor the VPAupdatercomponent. - Add
extraArgs.feature-gates: InPlaceOrRecreate=truefor the VPAadmissionControllercomponent. - Fix the upstream values reference comment from Goldilocks to VPA and add TODO notes for later removal once GA.
github-project-automation
bot
moved this from 🚀 In Finalization
to ✅ Done
in 🌊 Project Board
Contributor
|
🎉 This PR is included in version 2.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable VPA InPlaceOrRecreate feature gate for
updaterandadmissionControllercomponents in the standalone VPA helm-release. Also fixes the values comment URL from Goldilocks to VPA.Changes
extraArgswithfeature-gates: InPlaceOrRecreate=trueto bothupdaterandadmissionControllerin the VPA helm-releasegoldilocks/values.yamltovpa/values.yamlContext
Issues #993 and #990 (remove VPA image overrides from Goldilocks sub-chart) were already resolved when VPA was separated into a standalone helm release. Those issues are now closed.
Issue #989 (remove InPlaceOrRecreate extraArgs when VPA supports it by default) remains open — the feature gates were lost during the VPA restructuring and are now re-enabled. They can be removed once VPA chart reaches appVersion 1.6.0+ where InPlaceOrRecreate is GA.
Closes #993
Closes #990
Refs #989