feat(apps): verify cosign signatures on app OCI artifacts#1559
Merged
Conversation
Enable keyless cosign signature verification on the wedding-app and ascoachingogvaner OCIRepositories. Artifacts are signed in publish-app.yaml via GitHub Actions OIDC (Fulcio/Rekor), so source-controller now rejects any manifest not signed by that reusable workflow before reconciling it. The subject regex matches the reusable workflow path with any pinned ref, so it survives Renovate/Dependabot bumps of the workflow SHA without breaking verification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![botantler[bot]](https://avatars.githubusercontent.com/in/1025824?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Enables keyless Cosign signature verification (spec.verify) for the Flux OCIRepository sources that drive the wedding-app and ascoachingogvaner app deployments, so source-controller will only reconcile OCI artifacts signed by the intended GitHub Actions reusable workflow identity.
Changes:
- Added
spec.verify.provider: cosignto both appOCIRepositoryresources. - Added
spec.verify.matchOIDCIdentityconstraints (issuer + subject regex) matching the GitHub Actions OIDC identity ofdevantler-tech/reusable-workflows/.github/workflows/publish-app.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| k8s/bases/apps/wedding-app/sync.yaml | Enables Cosign keyless verification on the wedding-app OCIRepository using issuer/subject identity matching. |
| k8s/bases/apps/ascoachingogvaner/sync.yaml | Enables Cosign keyless verification on the ascoachingogvaner OCIRepository using the same issuer/subject identity matching. |
Contributor
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.verify) on thewedding-appandascoachingogvanerOCIRepositories.reusable-workflows/.github/workflows/publish-app.yamlvia GitHub Actions OIDC (Fulcio/Rekor). source-controller now rejects any manifest not signed by that reusable workflow before reconciling it.Identity validated
The signing identity was extracted from the live signed artifacts (cert SAN) and validated with
cosign verifyagainst bothwedding-app/manifests:1.5.9andascoachingogvaner/manifests:1.0.1:^https://token\.actions\.githubusercontent\.com$^https://github\.com/devantler-tech/reusable-workflows/\.github/workflows/publish-app\.yaml@.+$The subject matches the reusable workflow path with any pinned ref (
@.+), so it survives Renovate/Dependabot bumps of the workflow SHA without breaking verification. A negative control (wrong path) was confirmed to fail.Test plan
cosign verifyexit 0 for both artifacts with the resilient regexReady=True(verification passes against live artifacts, no reconciliation halt)Generated with Claude Code