Skip to content

Enhance file review status UI, improve error handling, and strengthen test coverage#12

Merged
devarshishimpi merged 8 commits into
devfrom
bug/file-review-status-bar-dashboard
May 25, 2026
Merged

Enhance file review status UI, improve error handling, and strengthen test coverage#12
devarshishimpi merged 8 commits into
devfrom
bug/file-review-status-bar-dashboard

Conversation

@devarshishimpi
Copy link
Copy Markdown
Owner

@devarshishimpi devarshishimpi commented May 24, 2026

Description

This PR improves the dashboard experience and system reliability by enhancing the file review status display, refactoring model error handling, and adding comprehensive test coverage. The changes focus on providing better visibility into review job progress and status while ensuring more robust error recovery and webhook handling.

Closes #8

What's Changed

UI/UX Improvements:

  • Enhanced job logs page with detailed file review status cards showing individual file progress
  • Improved job detail metadata cards with better visual hierarchy and responsive layout
  • Added live review stepper UI for tracking multi-file review progress
  • Enhanced Sonner toast notifications styling and job status indicators
  • Better visual feedback for file status states (done, pending, failed, skipped)

Backend Improvements:

  • Refactored model error handling with improved distinction between retryable and terminal errors
  • Enhanced job recovery mechanisms with better lease expiration handling
  • Improved webhook routing and error propagation
  • Added retry delay escalation for transient model provider failures

Testing:

  • Added comprehensive test coverage for model service error scenarios
  • Added webhook handling tests for error cases
  • Enhanced review flow tests with improved error handling verification

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (improving status visibility and error recovery)
  • Refactoring (error handling and code organization)

How Has This Been Tested?

  • Unit Tests - Added tests for model error handling, webhook routing, and review flow
  • Manual Dashboard Verification - Tested job detail and logs page UI with various file review states
  • Manual GitHub Webhook Verification - Verified webhook error handling and retry mechanisms

Checklist:

  • I have starred Codra on GitHub
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have signed the CLA

codra-app-personal[bot]

This comment was marked as resolved.

codra-app-personal[bot]

This comment was marked as resolved.

codra-app-personal[bot]

This comment was marked as resolved.

codra-app-personal[bot]

This comment was marked as resolved.

codra-app-personal[bot]

This comment was marked as resolved.

codra-app-personal[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@codra-app-personal codra-app-personal Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codra Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b2df7dfd6

ℹ️ About Codra in GitHub

Your team has set up Codra to review pull requests in this repo. Reviews are triggered when you:

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codra-app review"

If Codra has suggestions, it will comment; otherwise it will react with 👍.

Codra can also answer questions or update the PR. Try commenting "@codra-app address that feedback".

Comment thread src/client/app.css
Comment thread src/client/app.css
Comment thread src/client/components/features/reviews/live-review-stepper.tsx
Comment thread src/client/components/features/reviews/live-review-stepper.tsx
Comment thread src/client/components/features/reviews/live-review-stepper.tsx
Comment thread src/server/core/job-recovery.ts
Comment thread src/server/core/review.ts
Comment thread src/server/core/review.ts
Comment thread src/server/core/review.ts
Comment thread src/server/core/model-output.ts
@devarshishimpi devarshishimpi merged commit cc479e3 into dev May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant