Make Installation namespace consistent #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By prefixing all classes with `Installation` instead of `GitHubInstallation` or nothing we are more consistant
msvrtan
force-pushed
the
113-installation-consistency
branch
from
b04996c to
1b1b20d
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it should do
Make Devboard\GitHub\Installation namespace consistent. Up to now, some classes were prefixed with
GitHubInstallationwhile some had no prefix. GitHub prefix is not needed.Story
In order to improve consistency
For developers ,
We will **make all Installation classes prefixed with
Installationonly **Whereas currently we had both
GitHubInstallationand no prefixReferences
Closes #113